Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error with natural height when no lines exist #37

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

StevenEWright
Copy link
Contributor

@StevenEWright StevenEWright commented Aug 29, 2023

Fixes a potential error that can occur when there are no text lines or the text metrics haven't been measured when the total height is requested.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
  • I <Steven E Wright> agree to the Developer Certificate of Origin
  • I have reviewed the License Agreement at
    LICENSE.md

@github-actions
Copy link

size-limit report 📦

Path Size
./dist/kullna-editor.min.js 7.68 KB (+0.32% 🔺)

@StevenEWright StevenEWright merged commit 7706db5 into main Aug 29, 2023
3 checks passed
@StevenEWright StevenEWright deleted the swright/fix_natural_height_error branch August 29, 2023 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant